noctra/iproute2-next
1
0
Fork 0
Code Issues Pull Requests Releases Activity

devlink: use the correct handle flag for port param show

Browse Source 
Port param show command arg parser used the devlink dev flag
instead of the port, which caused to not identify the port device
argument, causing the following error:

$ devlink port param show eth0 name link_type
Wrong identification string format.
Devlink identification ("bus_name/dev_name") expected

Use the correct the devlink handle flag.

Fixes: 70faecdca8 ("devlink: implement dump selector for devlink objects show commands")
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
This commit is contained in:
Saeed Mahameed
2024-11-26 10:08:28 +01:00
committed by Stephen Hemminger
parent 8c4918859e
commit 413cf4f03a
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
devlink/devlink.c
View File

@@ -5089,7 +5089,7 @@ static int cmd_port_param_show(struct dl *dl)
err = dl_argv_parse_with_selector(dl, &flags,
DEVLINK_CMD_PORT_PARAM_GET,
DL_OPT_HANDLE | DL_OPT_PARAM_NAME, 0,
DL_OPT_HANDLEP | DL_OPT_PARAM_NAME, 0,
DL_OPT_HANDLE | DL_OPT_HANDLEP, 0);
if (err)
return err;