noctra/iproute2-next
1
0
Fork 0
Code Issues Pull Requests Releases Activity

tc: Add space after format specifier

Browse Source 
Add space after format specifier in print_string call. Fixes broken
qdisc tests within tdc testing suite. Per suggestion from Petr Machata,
remove a space and change spacing in tc/q_event.c to complete the fix.

Tested fix in tdc using:
./tdc.py -c qdisc

All qdisc RED tests return ok.

Fixes: d0e450438571("tc: q_red: Add support for qevents "mark" and "early_drop")
Signed-off-by: Briana Oursler <briana.oursler@gmail.com>
Tested-by: Petr Machata <petrm@mellanox.com>
Signed-off-by: David Ahern <dsahern@kernel.org>
This commit is contained in:
Briana Oursler
2020-07-27 22:20:48 -07:00
committed by David Ahern
parent 1ca65af1c5
commit 41a9e38469
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tc/q_red.c
View File

@@ -222,12 +222,12 @@ static int red_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt)
print_uint(PRINT_JSON, "min", NULL, qopt->qth_min);
print_string(PRINT_FP, NULL, "min %s ", sprint_size(qopt->qth_min, b2));
print_uint(PRINT_JSON, "max", NULL, qopt->qth_max);
print_string(PRINT_FP, NULL, "max %s", sprint_size(qopt->qth_max, b3));
print_string(PRINT_FP, NULL, "max %s ", sprint_size(qopt->qth_max, b3));
tc_red_print_flags(qopt->flags);
if (show_details) {
print_uint(PRINT_ANY, "ewma", " ewma %u ", qopt->Wlog);
print_uint(PRINT_ANY, "ewma", "ewma %u ", qopt->Wlog);
if (max_P)
print_float(PRINT_ANY, "probability",
"probability %lg ", max_P / pow(2, 32));

3
tc/tc_qevent.c
View File

@@ -82,8 +82,9 @@ void qevents_print(struct qevent_util *qevents, FILE *f)
}
open_json_object(NULL);
print_string(PRINT_ANY, "kind", " qevent %s", qevents->id);
print_string(PRINT_ANY, "kind", "qevent %s", qevents->id);
qevents->print_qevent(qevents, f);
print_string(PRINT_FP, NULL, "%s", " ");
close_json_object();
}
}