noctra/iproute2-next
1
0
Fork 0
Code Issues Pull Requests Releases Activity

ip: check return value of iproute_flush_cache() in irpoute.c

Browse Source 
Static analyzer reported:
Return value of function 'iproute_flush_cache', called at iproute.c:1732,
is not checked. The return value is obtained from function 'open64' and possibly contains an error code.

Corrections explained:
The function iproute_flush_cache() may return an error code, which was
previously ignored. This could lead to unexpected behavior if the cache
flush fails. Added error handling to ensure the function fails gracefully
when iproute_flush_cache() returns an error.

Triggers found by static analyzer Svace.

Signed-off-by: Anton Moryakov <ant.v.moryakov@gmail.com>
Signed-off-by: David Ahern <dsahern@kernel.org>
This commit is contained in:
Anton Moryakov
2025-02-17 19:21:50 +03:00
committed by David Ahern
parent e7638a027a
commit 84da3f37e2
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
ip/iproute.c
View File

@@ -1729,7 +1729,10 @@ static int iproute_flush(int family, rtnl_filter_t filter_fn)
if (filter.cloned) {
if (family != AF_INET6) {
iproute_flush_cache();
ret = iproute_flush_cache();
if (ret < 0)
return ret;
if (show_stats)
printf("*** IPv4 routing cache is flushed.\n");
}