noctra/iproute2-next
1
0
Fork 0
Code Issues Pull Requests Releases Activity

lib: remove redundant checks in get_u64 and get_s64

Browse Source 
Static analyzer reported:
1. if (res > 0xFFFFFFFFFFFFFFFFULL)
Expression 'res > 0xFFFFFFFFFFFFFFFFULL' is always false , which may be caused by a logical error:
'res' has a type 'unsigned long long' with minimum value '0' and a maximum value '18446744073709551615'

2. if (res > INT64_MAX || res < INT64_MIN)
Expression 'res > INT64_MAX' is always false , which may be caused by a logical error: 'res' has a type 'long long'
with minimum value '-9223372036854775808' and a maximum value '9223372036854775807'
Expression 'res < INT64_MIN' is always false , which may be caused by a logical error: 'res' has a type 'long long'
with minimum value '-9223372036854775808' and a maximum value '9223372036854775807'

Corrections explained:
- Removed redundant check `res > 0xFFFFFFFFFFFFFFFFULL` in `get_u64`,
  as `res` cannot exceed this value due to its type.
- Removed redundant checks `res > INT64_MAX` and `res < INT64_MIN` in `get_s64`,
  as `res` cannot exceed the range of `long long`.

Triggers found by static analyzer Svace.

Signed-off-by: Anton Moryakov <ant.v.moryakov@gmail.com>
Signed-off-by: David Ahern <dsahern@kernel.org>
This commit is contained in:
Anton Moryakov
2025-02-17 19:21:53 +03:00
committed by David Ahern
parent 46bbbaf114
commit aca230f0f5
1 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/utils.c
View File

@@ -304,10 +304,6 @@ int get_u64(__u64 *val, const char *arg, int base)
if (res == ULLONG_MAX && errno == ERANGE)
return -1;
/* in case ULL is 128 bits */
if (res > 0xFFFFFFFFFFFFFFFFULL)
return -1;
*val = res;
return 0;
}
@@ -399,8 +395,6 @@ int get_s64(__s64 *val, const char *arg, int base)
return -1;
if ((res == LLONG_MIN || res == LLONG_MAX) && errno == ERANGE)
return -1;
if (res > INT64_MAX || res < INT64_MIN)
return -1;
*val = res;
return 0;